-
-
Notifications
You must be signed in to change notification settings - Fork 771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
5/Test GrantCLRCalculation model #9396
Merged
thelostone-mc
merged 11 commits into
gitcoinco:master
from
jeremyschuurmans:test-grant-clr-calculation
Sep 29, 2021
Merged
5/Test GrantCLRCalculation model #9396
thelostone-mc
merged 11 commits into
gitcoinco:master
from
jeremyschuurmans:test-grant-clr-calculation
Sep 29, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremyschuurmans
requested review from
chibie,
frankchen07,
gdixon,
octavioamu,
PixelantDesign,
thelostone-mc and
zlsgh
as code owners
August 26, 2021 18:58
jeremyschuurmans
changed the title
Test GrantCLRCalculation model
WIP: 5/Test GrantCLRCalculation model
Sep 15, 2021
jeremyschuurmans
force-pushed
the
add-grants-unit-tests
branch
3 times, most recently
from
September 22, 2021 18:35
69bb98a
to
81f1318
Compare
jeremyschuurmans
changed the title
WIP: 5/Test GrantCLRCalculation model
5/Test GrantCLRCalculation model
Sep 22, 2021
jeremyschuurmans
force-pushed
the
test-grant-clr-calculation
branch
from
September 22, 2021 21:18
4cce351
to
ad0b3f4
Compare
jeremyschuurmans
changed the base branch from
add-grants-unit-tests
to
master
September 27, 2021 20:25
* create new directory for models, copy over Contribution model * extract grants models to individual files * rename relocated_models directory, remove original models directory, add imports, resolve circular dependencies * extract CLRMatch into separate file * extract Flag into separate file * extract MatchPledge to separate file * extract Donation and PhantomFunding * extract GrantStat into separate file * refactor * extract GrantBrandingRoutingPolicy to separate file * update migration * add missing import to MatchPledge, remove imports from __init__.py * add missing import * decouple GrantCLRCalculation and move to own file * extract GrantType to own file * extract GrantCLR to own file * add missing import * refactor, add missing imports * remove whitespace * resolve circular dependency * run 'make fix' * import changes from gitcoinco#9314 * add try/except to migration file instead of editing migration directly * refactor
jeremyschuurmans
force-pushed
the
test-grant-clr-calculation
branch
from
September 27, 2021 20:26
ad0b3f4
to
1317e03
Compare
thelostone-mc
approved these changes
Sep 29, 2021
thelostone-mc
approved these changes
Sep 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds unit tests for GrantCLRCalculation model
Refers/Fixes
Testing